Add %LJ (joined with spaces) to qsprintf() for merging JOIN clauses
ClosedPublic
Actions

Authored by epriestley on Nov 7 2018, 10:48 AM.

Details

Reviewers

amckinley

Maniphest Tasks

T13217: Upgrading: Hardening of qsprintf()

Commits

rPHU3c1f820b6356: Add %LJ (joined with spaces) to qsprintf() for merging JOIN clauses

Summary

Depends on D19783. Ref T13217. Beyond AND, OR, and comma, we also need spaces to join JOIN clauses. Add %LJ, like the other query sublist conversions.

Test Plan

See upcoming changes.

Diff Detail

Repository

rPHU libphutil

Branch

qobject6

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21101
Build 28680: Run Core Tests
Build 28679: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 7 2018, 10:48 AM

Harbormaster completed remote builds in B21101: Diff 47252.Nov 7 2018, 10:48 AM

epriestley requested review of this revision.Nov 7 2018, 10:48 AM

epriestley added a child revision: D19787: Make %LO, %LA, %LQ and %LJ more lax in what they accept (warnings instead of exceptions).Nov 7 2018, 11:59 AM

amckinley accepted this revision.Nov 8 2018, 12:03 AM

This revision is now accepted and ready to land.Nov 8 2018, 12:03 AM

Closed by commit rPHU3c1f820b6356: Add %LJ (joined with spaces) to qsprintf() for merging JOIN clauses (authored by epriestley). · Explain WhyNov 13 2018, 4:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

xsprintf/

qsprintf.php

12 lines

Diff 47252

View Options

Add %LJ (joined with spaces) to qsprintf() for merging JOIN clausesClosedPublicActions