Page MenuHomePhabricator

Fix class attribute node in anonymous class
ClosedPublic

Authored by wjiang on Oct 9 2018, 1:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 9, 1:11 PM
Unknown Object (File)
Nov 11 2024, 5:56 AM
Unknown Object (File)
Nov 4 2024, 10:40 AM
Unknown Object (File)
Nov 4 2024, 10:40 AM
Unknown Object (File)
Nov 4 2024, 10:40 AM
Unknown Object (File)
Nov 3 2024, 1:54 AM
Unknown Object (File)
Nov 1 2024, 10:47 PM
Unknown Object (File)
Oct 24 2024, 5:43 PM

Details

Summary

Ref T4334. The class attribute node of an anonymous class should be n_EMPTY.

Test Plan

Tested with phabricator xhpast view

1.png (324×475 px, 14 KB)

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsupport/xhpast/xhpast.cpp:0Cppchecktoomanyconfigs
Unit
Tests Passed
Build Status
Buildable 21005
Build 28534: arc lint + arc unit

Event Timeline

wjiang requested review of this revision.Oct 9 2018, 1:39 AM

I think maybe we should keep it as an empty n_CLASS_ATTRIBUTES in case attributes are added later.

I think maybe we should keep it as an empty n_CLASS_ATTRIBUTES in case attributes are added later.

Hmm.. I doubt that'll happen as anonymous class can never be extended.

@epriestley, would you mind taking a look at this diff?

This revision is now accepted and ready to land.May 14 2019, 2:21 PM
This revision was landed with ongoing or failed builds.May 15 2019, 12:55 AM
This revision was automatically updated to reflect the committed changes.