Page MenuHomePhabricator
Differential D19740

Fix class attribute node in anonymous class
ClosedPublic
Actions

Authored by wjiang on Oct 9 2018, 1:39 AM.
Tags
None
Referenced Files
F13050467: D19740.id48926.diff
Fri, Apr 19, 2:55 AM
F13050466: D19740.id47162.diff
Fri, Apr 19, 2:55 AM
F13050465: D19740.id.diff
Fri, Apr 19, 2:55 AM
Unknown Object (File)
Thu, Apr 11, 10:38 AM
Unknown Object (File)
Thu, Apr 11, 4:09 AM
Unknown Object (File)
Fri, Apr 5, 9:37 AM
Unknown Object (File)
Fri, Apr 5, 9:15 AM
Unknown Object (File)
Fri, Mar 29, 12:39 AM
View All Files
Subscribers
epriestley
Firehed
Korvin

Details

Reviewers
joshuaspence
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4334: Support PHP5.4+ syntax in XHPAST
Summary

Ref T4334. The class attribute node of an anonymous class should be n_EMPTY.

Test Plan

Tested with phabricator xhpast view

1.png (324×475 px, 14 KB)

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

wjiang created this revision.Oct 9 2018, 1:39 AM
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 9 2018, 1:39 AM
Herald added subscribers: Firehed, epriestley. · View Herald Transcript
wjiang requested review of this revision.Oct 9 2018, 1:39 AM
Harbormaster completed remote builds in B21005: Diff 47162.Oct 9 2018, 1:39 AM
wjiang edited the test plan for this revision. (Show Details)Oct 9 2018, 1:39 AM
joshuaspence added a comment.Oct 9 2018, 1:43 AM

I think maybe we should keep it as an empty n_CLASS_ATTRIBUTES in case attributes are added later.

wjiang added a comment.Oct 9 2018, 1:47 AM
In D19740#244818, @joshuaspence wrote:

I think maybe we should keep it as an empty n_CLASS_ATTRIBUTES in case attributes are added later.

Hmm.. I doubt that'll happen as anonymous class can never be extended.

joshuaspence accepted this revision.Oct 9 2018, 3:31 AM
wjiang added a child revision: D19741: Let lint rules support anonymous classes.Oct 10 2018, 12:04 AM
joshuaspence added a comment.Oct 10 2018, 11:31 PM

@epriestley, would you mind taking a look at this diff?

epriestley accepted this revision.May 14 2019, 2:21 PM
This revision is now accepted and ready to land.May 14 2019, 2:21 PM
Herald added a subscriber: Korvin. · View Herald TranscriptMay 14 2019, 2:21 PM
This revision was landed with ongoing or failed builds.May 15 2019, 12:55 AM
Closed by commit rPHU6c83b169bc18: Fix class attribute node in anonymous class (authored by wjiang, committed by joshuaspence). · Explain Why
This revision was automatically updated to reflect the committed changes.
joshuaspence added an edge: rPHU6c83b169bc18: Fix class attribute node in anonymous class.

Revision Contents
Changeset List

PathSize
src/
parser/
xhpast/
__tests__/
data/
12 lines
bin/
2 lines
support/
xhpast/
2 lines
2 lines

Diff 48926

View Options

src/parser/xhpast/__tests__/data/anonymous_class.php.test

Loading...
View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

Loading...
View Options

support/xhpast/parser.y

Loading...
View Options

support/xhpast/parser.yacc.cpp

Loading...
View Options

support/xhpast/xhpast.cpp

Loading...
Phabricator · Built by Phacility