Page MenuHomePhabricator

Fix fatal in rendering Phriction "Moved Away" stories
ClosedPublic

Authored by epriestley on Sep 17 2018, 10:13 PM.
Tags
None
Referenced Files
F15466476: D19682.diff
Thu, Apr 3, 6:00 AM
F15453177: D19682.id.diff
Sat, Mar 29, 9:58 AM
F15440228: D19682.diff
Wed, Mar 26, 11:27 AM
F15438452: D19682.id47033.diff
Wed, Mar 26, 12:46 AM
F15435273: D19682.id47035.diff
Tue, Mar 25, 7:39 AM
F15430000: D19682.id.diff
Mon, Mar 24, 5:12 AM
F15426774: D19682.diff
Sun, Mar 23, 10:48 AM
Unknown Object (File)
Mar 3 2025, 8:27 PM
Subscribers
None

Details

Summary

Ref T13202. See PHI881. These stories have bad rendering methods, but they didn't previously render into the timeilne (since Phriction documents didn't have a timeline).

Update the rendering to work.

The rendered outcome isn't great (it isn't very clear or explicit about exactly what moved where), but I'll fix that in a followup. This is a net improvement since it doesn't fatal the page, at least.

Test Plan
  • Moved page "X" to "Y".
  • Viewed the old page "X".
  • Before patch: bad timeline story would fatal rendering.
  • After patch: story renders, at least, just not great.

Diff Detail

Repository
rP Phabricator
Branch
wiki1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20844
Build 28352: Run Core Tests
Build 28351: arc lint + arc unit

Event Timeline

I'm going to bring this and D19683 to stable and hotfix them to web.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 18 2018, 3:02 AM
This revision was automatically updated to reflect the committed changes.