Page MenuHomePhabricator

Fix Phriction rendering for initial install and 404 pages
ClosedPublic

Authored by epriestley on Sep 17 2018, 10:18 PM.

Details

Summary

Depends on D19682. Ref T13202. We currently fatal when trying to render a timeline if:

  • an install is fresh, so there are no pages yet, and you look at "/w/"; or
  • you're looking at a Phriction page which doesn't exist (yet) like "/w/aadsflknadsflnf/".

Rendering a timeline and comment area doesn't make sense in these cases, so don't render them.

Test Plan

Hit both cases described above, got "new/empty page" prompts instead of fatals.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 18 2018, 3:03 AM
This revision was automatically updated to reflect the committed changes.