Page MenuHomePhabricator

Fix fatal in rendering Phriction "Moved Away" stories
ClosedPublic

Authored by epriestley on Sep 17 2018, 10:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 9:25 PM
Unknown Object (File)
Fri, Nov 15, 6:54 PM
Unknown Object (File)
Mon, Nov 11, 11:50 PM
Unknown Object (File)
Fri, Nov 8, 9:55 AM
Unknown Object (File)
Mon, Nov 4, 11:23 PM
Unknown Object (File)
Sat, Nov 2, 6:22 AM
Unknown Object (File)
Oct 21 2024, 3:45 PM
Unknown Object (File)
Oct 14 2024, 11:05 PM
Subscribers
None

Details

Summary

Ref T13202. See PHI881. These stories have bad rendering methods, but they didn't previously render into the timeilne (since Phriction documents didn't have a timeline).

Update the rendering to work.

The rendered outcome isn't great (it isn't very clear or explicit about exactly what moved where), but I'll fix that in a followup. This is a net improvement since it doesn't fatal the page, at least.

Test Plan
  • Moved page "X" to "Y".
  • Viewed the old page "X".
  • Before patch: bad timeline story would fatal rendering.
  • After patch: story renders, at least, just not great.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I'm going to bring this and D19683 to stable and hotfix them to web.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 18 2018, 3:02 AM
This revision was automatically updated to reflect the committed changes.