Page MenuHomePhabricator

Fix fatal in rendering Phriction "Moved Away" stories
ClosedPublic

Authored by epriestley on Sep 17 2018, 10:13 PM.
Tags
None
Referenced Files
F17843258: D19682.id47033.diff
Sun, Jul 27, 12:42 AM
F17820428: D19682.diff
Sat, Jul 26, 1:59 AM
F17761204: D19682.id47035.diff
Tue, Jul 22, 8:32 PM
F17760165: D19682.id47033.diff
Tue, Jul 22, 7:17 PM
F17755401: D19682.id.diff
Tue, Jul 22, 12:19 PM
F17739676: D19682.diff
Mon, Jul 21, 3:22 AM
Unknown Object (File)
Jun 2 2025, 2:04 PM
Unknown Object (File)
May 5 2025, 10:42 AM
Subscribers
None

Details

Summary

Ref T13202. See PHI881. These stories have bad rendering methods, but they didn't previously render into the timeilne (since Phriction documents didn't have a timeline).

Update the rendering to work.

The rendered outcome isn't great (it isn't very clear or explicit about exactly what moved where), but I'll fix that in a followup. This is a net improvement since it doesn't fatal the page, at least.

Test Plan
  • Moved page "X" to "Y".
  • Viewed the old page "X".
  • Before patch: bad timeline story would fatal rendering.
  • After patch: story renders, at least, just not great.

Diff Detail

Repository
rP Phabricator
Branch
wiki1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20844
Build 28352: Run Core Tests
Build 28351: arc lint + arc unit

Event Timeline

I'm going to bring this and D19683 to stable and hotfix them to web.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 18 2018, 3:02 AM
This revision was automatically updated to reflect the committed changes.