Paths

Table of Contentst

Differential D19651

Make DiffusionCommitSearch accept modern (string) constants
ClosedPublic
Actions

Authored by epriestley on Sep 10 2018, 7:11 PM.

Tags

None

Referenced Files

	F14104068: D19651.id46965.diff
	Tue, Nov 26, 11:38 PM

	F14103398: D19651.diff
	Tue, Nov 26, 10:00 PM

	Unknown Object (File)
	Sun, Nov 10, 2:08 PM

	Unknown Object (File)
	Oct 27 2024, 9:40 AM

	Unknown Object (File)
	Oct 15 2024, 3:08 AM

	Unknown Object (File)
	Sep 12 2024, 9:06 AM

	Unknown Object (File)
	Sep 12 2024, 9:06 AM

	Unknown Object (File)
	Sep 6 2024, 3:51 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13197: 2018 Week 37 Bonus Content

Commits

rP8eb8e8e1d86f: Make DiffusionCommitSearch accept modern (string) constants

Summary

Depends on D19650. Ref T13197. Allow SearchCheckboxesField to have a "deprecated" map of older aliases, then convert them to modern values.

On the API method page, show all the values.

This technically resolves the issue in PHI841, although I still plan to migrate behind this.

Test Plan

Screen Shot 2018-09-10 at 12.10.21 PM.png (575×569 px, 68 KB)

Queried audits, fiddled with ?status=1,audited, etc.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 10 2018, 7:11 PM

Harbormaster completed remote builds in B20775: Diff 46965.Sep 10 2018, 7:13 PM

epriestley requested review of this revision.Sep 10 2018, 7:13 PM

epriestley edited the summary of this revision. (Show Details)Sep 10 2018, 7:13 PM

epriestley marked an inline comment as done.

epriestley added inline comments.

src/applications/audit/constants/PhabricatorAuditCommitStatusConstants.php
96–126	No more callers for this stuff.

epriestley added a child revision: D19652: Migrate old commit saved queries to new audit status constants.Sep 10 2018, 7:50 PM

amckinley accepted this revision.Sep 10 2018, 9:09 PM

amckinley added inline comments.

src/applications/search/engine/PhabricatorSearchEngineAPIMethod.php
233–237	Should we add a little icon in this column to match the appearance of frozen conduit methods? (This is is kind of an actual consistency issue). Or alternately, add 💚vs ❌on every row? (This is just bike-shedding).

This revision is now accepted and ready to land.Sep 10 2018, 9:09 PM

Add a little /!\ icon for deprecated, like Conduit methods get a level above.

Yeah, that's reasonable:

Screen Shot 2018-09-10 at 2.37.57 PM.png (529×579 px, 67 KB)

Although let me fiddle with this a little bit since it looks a touch awkward now.

Harbormaster completed remote builds in B20780: Diff 46970.Sep 10 2018, 9:40 PM

Since the description is clear about "deprecated" anyway, just put the icon there instead of in a weird column?

This seems a little better, I think?

Screen Shot 2018-09-10 at 2.40.27 PM.png (550×528 px, 60 KB)

Harbormaster completed remote builds in B20781: Diff 46971.Sep 10 2018, 9:42 PM

This seems a little better, I think?

Looks good to me.

Closed by commit rP8eb8e8e1d86f: Make DiffusionCommitSearch accept modern (string) constants (authored by epriestley). · Explain WhySep 10 2018, 11:25 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

constants/

PhabricatorAuditCommitStatusConstants.php

27 lines

query/

PhabricatorCommitSearchEngine.php

4 lines

conduit/

data/

ConduitConstantDescription.php

10 lines

search/

engine/

PhabricatorSearchEngineAPIMethod.php

15 lines

field/

PhabricatorSearchCheckboxesField.php

37 lines

Diff 46974

src/applications/audit/constants/PhabricatorAuditCommitStatusConstants.php

Loading...

src/applications/audit/query/PhabricatorCommitSearchEngine.php

Loading...

src/applications/conduit/data/ConduitConstantDescription.php

Loading...

src/applications/search/engine/PhabricatorSearchEngineAPIMethod.php

Loading...

src/applications/search/field/PhabricatorSearchCheckboxesField.php

Loading...