Page MenuHomePhabricator

Work around an issue in MariaDB where dropping a column from a UNIQUE KEY fails
ClosedPublic

Authored by epriestley on Aug 30 2018, 1:18 PM.
Tags
None
Referenced Files
F13213948: D19624.diff
Fri, May 17, 8:17 AM
F13207406: D19624.id46909.diff
Wed, May 15, 11:15 PM
F13198816: D19624.diff
Mon, May 13, 10:05 AM
Unknown Object (File)
Tue, May 7, 9:33 AM
Unknown Object (File)
Fri, May 3, 9:21 AM
Unknown Object (File)
Thu, May 2, 5:16 AM
Unknown Object (File)
Thu, Apr 25, 2:59 AM
Unknown Object (File)
Fri, Apr 19, 7:54 PM
Subscribers
Restricted Owners Package

Details

Summary

See T13193. See T13077. If we drop a column which is part of a UNIQUE KEY, MariaDB raises an error.

This is probably a bad idea on our side anyway, but in this case it wasn't an obviously bad idea.

To get around this:

  • Drop the unique key, if it exists, before dropping the column.
  • Explicitly add the new unique key afterward.
Test Plan

Ran bin/storage upgrade locally without issue, but I'm on MySQL. Will follow up on T13193.

Diff Detail

Repository
rP Phabricator
Branch
phriction8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20714
Build 28157: Run Core Tests
Build 28156: arc lint + arc unit