Page MenuHomePhabricator

Work around an issue in MariaDB where dropping a column from a UNIQUE KEY fails
ClosedPublic

Authored by epriestley on Aug 30 2018, 1:18 PM.
Tags
None
Referenced Files
F13134795: D19624.diff
Thu, May 2, 5:16 AM
Unknown Object (File)
Thu, Apr 25, 2:59 AM
Unknown Object (File)
Fri, Apr 19, 7:54 PM
Unknown Object (File)
Wed, Apr 10, 12:03 PM
Unknown Object (File)
Mar 19 2024, 3:32 PM
Unknown Object (File)
Mar 19 2024, 3:32 PM
Unknown Object (File)
Mar 19 2024, 3:32 PM
Unknown Object (File)
Mar 19 2024, 3:31 PM
Subscribers
Restricted Owners Package

Details

Summary

See T13193. See T13077. If we drop a column which is part of a UNIQUE KEY, MariaDB raises an error.

This is probably a bad idea on our side anyway, but in this case it wasn't an obviously bad idea.

To get around this:

  • Drop the unique key, if it exists, before dropping the column.
  • Explicitly add the new unique key afterward.
Test Plan

Ran bin/storage upgrade locally without issue, but I'm on MySQL. Will follow up on T13193.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable