Page MenuHomePhabricator

Work around an issue in MariaDB where dropping a column from a UNIQUE KEY fails
ClosedPublic

Authored by epriestley on Aug 30 2018, 1:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 30, 10:21 PM
Unknown Object (File)
Sun, Jun 29, 6:10 PM
Unknown Object (File)
Sun, Jun 29, 7:11 AM
Unknown Object (File)
May 29 2025, 10:33 AM
Unknown Object (File)
May 28 2025, 8:49 AM
Unknown Object (File)
May 8 2025, 8:08 AM
Unknown Object (File)
May 8 2025, 3:25 AM
Unknown Object (File)
May 7 2025, 11:56 PM
Subscribers
Restricted Owners Package

Details

Summary

See T13193. See T13077. If we drop a column which is part of a UNIQUE KEY, MariaDB raises an error.

This is probably a bad idea on our side anyway, but in this case it wasn't an obviously bad idea.

To get around this:

  • Drop the unique key, if it exists, before dropping the column.
  • Explicitly add the new unique key afterward.
Test Plan

Ran bin/storage upgrade locally without issue, but I'm on MySQL. Will follow up on T13193.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable