Page MenuHomePhabricator

Align web UI "Disable" and "Approve/Disapprove" flows with new "Can Disable Users" permission
ClosedPublic

Authored by epriestley on Aug 27 2018, 2:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 28, 8:44 PM
Unknown Object (File)
Wed, Nov 27, 3:43 AM
Unknown Object (File)
Thu, Nov 21, 3:10 AM
Unknown Object (File)
Tue, Nov 19, 12:54 AM
Unknown Object (File)
Fri, Nov 15, 8:55 AM
Unknown Object (File)
Mon, Nov 11, 6:25 AM
Unknown Object (File)
Thu, Nov 7, 2:19 PM
Unknown Object (File)
Thu, Nov 7, 1:46 PM
Subscribers
None

Details

Summary

Depends on D19606. Ref T13189. See PHI642.

  • Disabling/enabling users no longer requires admin. Now, you just need "Can Disable Users".
  • Update the UI to appropriately show the action in black or grey depending on what clicking the button will do.
  • For "Approve/Disapprove", fix a couple bugs, then let them go through without respect for "Can Disable Users". This is conceptually a different action, even though it ultimately sets the "Disabled" flag.
Test Plan
  • Disabled/enabled users from the web UI as various users, including a non-administrator with "Can Disable Users".
  • Hit permissions errors from the web UI as various users, including an administrator without "Can Disable Users".
  • Saw the "Disable/Enable" action activate properly based on whether clicking the button would actually work.
  • Disapproved a user without "Can Disable Users" permission, tried to re-disapprove a user.
  • Approved a user, tried to reapprove a user.

Diff Detail

Repository
rP Phabricator
Branch
disable4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20677
Build 28103: Run Core Tests
Build 28102: arc lint + arc unit