Page MenuHomePhabricator

Align web UI "Disable" and "Approve/Disapprove" flows with new "Can Disable Users" permission
ClosedPublic

Authored by epriestley on Aug 27 2018, 2:46 PM.
Tags
None
Referenced Files
F18705188: D19607.id.diff
Sun, Sep 28, 10:26 AM
F18701249: D19607.diff
Sat, Sep 27, 6:04 PM
F18650468: D19607.diff
Sun, Sep 21, 12:48 AM
F18599337: D19607.id46872.diff
Sat, Sep 13, 7:13 AM
F18509765: D19607.id.diff
Sep 5 2025, 3:35 AM
F18503206: D19607.diff
Sep 4 2025, 10:54 PM
F18140224: D19607.id46877.diff
Aug 14 2025, 3:52 AM
F18109747: D19607.id46872.diff
Aug 11 2025, 3:14 PM
Subscribers
None

Details

Summary

Depends on D19606. Ref T13189. See PHI642.

  • Disabling/enabling users no longer requires admin. Now, you just need "Can Disable Users".
  • Update the UI to appropriately show the action in black or grey depending on what clicking the button will do.
  • For "Approve/Disapprove", fix a couple bugs, then let them go through without respect for "Can Disable Users". This is conceptually a different action, even though it ultimately sets the "Disabled" flag.
Test Plan
  • Disabled/enabled users from the web UI as various users, including a non-administrator with "Can Disable Users".
  • Hit permissions errors from the web UI as various users, including an administrator without "Can Disable Users".
  • Saw the "Disable/Enable" action activate properly based on whether clicking the button would actually work.
  • Disapproved a user without "Can Disable Users" permission, tried to re-disapprove a user.
  • Approved a user, tried to reapprove a user.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable