Page MenuHomePhabricator
Differential D19604

Replace "Disable User" web UI flow with transactions
ClosedPublic
Actions

Authored by epriestley on Aug 27 2018, 1:35 PM.
Tags
None
Referenced Files
F18718414: D19604.id.diff
Mon, Sep 29, 3:56 PM
F18705874: D19604.diff
Sun, Sep 28, 1:39 PM
F18705496: D19604.id46869.diff
Sun, Sep 28, 11:37 AM
F18509761: D19604.id.diff
Sep 5 2025, 3:35 AM
F18503200: D19604.diff
Sep 4 2025, 10:54 PM
F18375495: D19604.id46869.diff
Aug 28 2025, 10:04 AM
F18362178: D19604.diff
Aug 27 2025, 1:19 PM
F18091840: D19604.id46874.diff
Aug 7 2025, 1:17 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13189: Plans: 2018 Week 35 Bonus Content
Commits
rP2f7b10c023b9: Replace "Disable User" web UI flow with transactions
Summary

Ref T13189. See PHI642. Upgrades the "Disable" action in the web UI to be transaction-based.

This technically breaks things a little (you can't disable non-bot users, since they now require CAN_EDIT and you won't have it) but an upcoming change will fix the permissions issue.

Test Plan

Disabled and enabled a (bot) user from the web UI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
people/
controller/
13 lines

Diff 46874

View Options

src/applications/people/controller/PhabricatorPeopleDisableController.php

Loading...
Phabricator · Built by Phacility