Deprecate Conduit method "diffusion.getrecentcommitsbypath"
ClosedPublic
Actions

Authored by epriestley on Aug 2 2018, 11:39 PM.

Details

Reviewers

amckinley

Commits

rP3574a55a95bd: Deprecate Conduit method "diffusion.getrecentcommitsbypath"

Summary

See D19558. This method has no callers and just wraps diffusion.historyquery, since D5960 (2013).

This was introduced in D315 (which didn't make it out of FB, I think) inside Facebook for unclear purposes in 2011.

Test Plan

Grepped for callers, found none.

Diff Detail

Repository

rP Phabricator

Branch

dep1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20561
Build 27928: Run Core Tests
Build 27927: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 2 2018, 11:39 PM

Harbormaster completed remote builds in B20561: Diff 46762.Aug 2 2018, 11:40 PM

epriestley requested review of this revision.Aug 2 2018, 11:40 PM

amckinley accepted this revision.Aug 2 2018, 11:58 PM

This revision is now accepted and ready to land.Aug 2 2018, 11:58 PM

artms awarded a token.Aug 3 2018, 6:40 AM

(You probably have years until this disappears from the upstream since it's already implemented in terms of diffusion.historyquery and we don't generally remove methods without some specific reason, but if you have opportunities to migrate toward diffusion.historyquery it couldn't hurt.)

Closed by commit rP3574a55a95bd: Deprecate Conduit method "diffusion.getrecentcommitsbypath" (authored by epriestley). · Explain WhyAug 3 2018, 4:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

conduit/

DiffusionGetRecentCommitsByPathConduitAPIMethod.php

8 lines

Diff 46762

View Options

src/applications/diffusion/conduit/DiffusionGetRecentCommitsByPathConduitAPIMethod.php

Deprecate Conduit method "diffusion.getrecentcommitsbypath"ClosedPublicActions