Page MenuHomePhabricator

Deprecate Conduit method "diffusion.getrecentcommitsbypath"
ClosedPublic

Authored by epriestley on Aug 2 2018, 11:39 PM.
Tags
None
Referenced Files
F14074337: D19559.diff
Thu, Nov 21, 5:54 AM
Unknown Object (File)
Sun, Nov 17, 2:43 AM
Unknown Object (File)
Oct 8 2024, 6:47 PM
Unknown Object (File)
Oct 8 2024, 6:47 PM
Unknown Object (File)
Oct 8 2024, 6:47 PM
Unknown Object (File)
Oct 8 2024, 6:24 PM
Unknown Object (File)
Sep 6 2024, 3:38 AM
Unknown Object (File)
Sep 1 2024, 3:52 PM
Subscribers
Tokens
"Like" token, awarded by artms.

Details

Summary

See D19558. This method has no callers and just wraps diffusion.historyquery, since D5960 (2013).

This was introduced in D315 (which didn't make it out of FB, I think) inside Facebook for unclear purposes in 2011.

Test Plan

Grepped for callers, found none.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Aug 2 2018, 11:58 PM

(You probably have years until this disappears from the upstream since it's already implemented in terms of diffusion.historyquery and we don't generally remove methods without some specific reason, but if you have opportunities to migrate toward diffusion.historyquery it couldn't hurt.)

This revision was automatically updated to reflect the committed changes.