Paths

Table of Contentst

Differential D19502

When queueing search index tasks, include the "objectPHID" in the task metadata
ClosedPublic
Actions

Authored by epriestley on Jun 22 2018, 12:40 PM.

Tags

None

Referenced Files

	F15538367: D19502.id46639.diff
	Thu, Apr 24, 6:48 PM

	F15537704: D19502.id46639.diff
	Thu, Apr 24, 3:15 PM

	F15526426: D19502.id46633.diff
	Mon, Apr 21, 8:51 PM

	F15515828: D19502.id.diff
	Fri, Apr 18, 1:39 PM

	F15515719: D19502.id46633.diff
	Fri, Apr 18, 12:55 PM

	F15512370: D19502.diff
	Thu, Apr 17, 10:02 AM

	F15510082: D19502.diff
	Wed, Apr 16, 6:37 PM

	F15446264: D19502.id46633.diff
	Mar 27 2025, 6:03 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13151: Plans: 2018 Week 23 - Week 30 Bonus Content

Commits

rPcbc71e75fae3: When queueing search index tasks, include the "objectPHID" in the task metadata

Summary

Ref T13151. See PHI719. One minor hiccup in debugging the issue (which ended up being "revision has 100K comments") was that the SearchWorker did not show which object it was indexing.

Add 'objectPHID' to the queue call so you can see which object is affected from the web UI.

Test Plan

Stopped daemons.
Used bin/search index D123 --background to queue a search task.
Viewed task details in web UI from /daemon/.
- Before change: no indication of which object was being indexed.
- After change: page helpfully shows that the task is indexing D123.

Diff Detail

Repository

Branch

search1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20439
Build 27761: Run Core Tests
Build 27760: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 22 2018, 12:40 PM

Harbormaster completed remote builds in B20439: Diff 46633.Jun 22 2018, 12:41 PM

epriestley requested review of this revision.Jun 22 2018, 12:41 PM

epriestley added a child revision: D19503: Index only the first 1,000 comments on any object.Jun 22 2018, 4:10 PM

amckinley accepted this revision.Jun 22 2018, 11:17 PM

This revision is now accepted and ready to land.Jun 22 2018, 11:17 PM

Closed by commit rPcbc71e75fae3: When queueing search index tasks, include the "objectPHID" in the task metadata (authored by epriestley). · Explain WhyJun 23 2018, 12:40 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

worker/

PhabricatorSearchWorker.php

1 line

Diff 46633

src/applications/search/worker/PhabricatorSearchWorker.php

Loading...