Page MenuHomePhabricator

Index only the first 1,000 comments on any object
ClosedPublic

Authored by epriestley on Jun 22 2018, 4:10 PM.
Tags
None
Referenced Files
F12841604: D19503.id46640.diff
Thu, Mar 28, 9:19 PM
Unknown Object (File)
Jan 11 2024, 7:49 PM
Unknown Object (File)
Jan 9 2024, 10:05 AM
Unknown Object (File)
Dec 24 2023, 3:46 AM
Unknown Object (File)
Dec 23 2023, 11:44 PM
Unknown Object (File)
Dec 7 2023, 1:01 AM
Unknown Object (File)
Nov 30 2023, 12:59 AM
Unknown Object (File)
Nov 15 2023, 11:22 AM
Subscribers
None

Details

Summary

Depends on D19502. Ref T13151. See PHI719. An install ended up with an object with 111,000+ comments on it because someone wrote a script to treat it like a logfile.

Although we seem to do mostly okay with this (locally, it only takes about 30s to index a similar object) we'll hit a wall somewhere (since we need to hold everything in memory), and it's hard to imagine a legitimate object with more than 1,000 comments. Just ignore comments past the first thousand.

(Conpherence threads may legitimately have more than 1,000 comments, but go through a different indexer.)

Test Plan
  • Piped some comments into maniphest.edit in a loop to create a task with 100K comments.
  • Ran bin/search index Txxx --force to reindex it, with --trace.
    • Before: task indexed in about 30s.
    • After: script loaded comments with LIMIT 1000 and indexed in a couple seconds.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable