Differential D19445

Apply the new patch byte size limit to mail patch generation in Differential
ClosedPublic
Actions

Authored by epriestley on May 10 2018, 5:19 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Feb 21, 2:56 AM

	Unknown Object (File)
	Fri, Feb 21, 2:56 AM

	Unknown Object (File)
	Fri, Feb 21, 2:56 AM

	Unknown Object (File)
	Fri, Feb 21, 2:56 AM

	Unknown Object (File)
	Sun, Feb 9, 6:04 AM

	Unknown Object (File)
	Sun, Feb 9, 6:04 AM

	Unknown Object (File)
	Sun, Feb 9, 6:04 AM

	Unknown Object (File)
	Sun, Feb 9, 6:04 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13137: Plans: 2018 Week 19 - Week 22 Bonus Content

Commits

rP26d0862f4f6f: Apply the new patch byte size limit to mail patch generation in Differential

Summary

Ref T13137. See PHI592. Depends on D19444. Apply a limit up front to stop patches which are way too big (e.g., 600MB of videos) from generating in the first place.

Test Plan

Configured inline patches in git format.
Created a normal revision, got an inline git patch.
Created a revision with a 10MB video file, got no inline patch.
(Added a bunch of debugging stuff to make sure the internal pathway was working.)

Diff Detail

Repository

Branch

large2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20318
Build 27589: Run Core Tests
Build 27588: arc lint + arc unit

Event Timeline

epriestley created this revision.May 10 2018, 5:19 PM

Harbormaster completed remote builds in B20318: Diff 46512.May 10 2018, 5:21 PM

epriestley requested review of this revision.May 10 2018, 5:21 PM

amckinley accepted this revision.May 10 2018, 7:21 PM

This revision is now accepted and ready to land.May 10 2018, 7:21 PM

Closed by commit rP26d0862f4f6f: Apply the new patch byte size limit to mail patch generation in Differential (authored by epriestley). · Explain WhyMay 14 2018, 4:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

14 lines

render/

DifferentialRawDiffRenderer.php

17 lines

Diff 46512

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...

src/applications/differential/render/DifferentialRawDiffRenderer.php

Loading...