Page MenuHomePhabricator

Apply the new patch byte size limit to mail patch generation in Differential
ClosedPublic

Authored by epriestley on May 10 2018, 5:19 PM.
Tags
None
Referenced Files
F21359115: D19445.diff
Sat, Jul 11, 8:53 AM
Unknown Object (File)
Jun 7 2026, 2:42 AM
Unknown Object (File)
Mar 7 2026, 10:40 AM
Unknown Object (File)
Mar 6 2026, 5:02 AM
Unknown Object (File)
Mar 6 2026, 5:01 AM
Unknown Object (File)
Feb 11 2026, 2:22 PM
Unknown Object (File)
Nov 4 2025, 2:29 AM
Unknown Object (File)
Nov 3 2025, 12:13 PM
Subscribers
None

Details

Summary

Ref T13137. See PHI592. Depends on D19444. Apply a limit up front to stop patches which are way too big (e.g., 600MB of videos) from generating in the first place.

Test Plan
  • Configured inline patches in git format.
  • Created a normal revision, got an inline git patch.
  • Created a revision with a 10MB video file, got no inline patch.
  • (Added a bunch of debugging stuff to make sure the internal pathway was working.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable