Page MenuHomePhabricator

Apply the new patch byte size limit to mail patch generation in Differential
ClosedPublic

Authored by epriestley on May 10 2018, 5:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 2:06 AM
Unknown Object (File)
Tue, Oct 29, 7:34 PM
Unknown Object (File)
Oct 20 2024, 2:15 AM
Unknown Object (File)
Oct 18 2024, 4:42 AM
Unknown Object (File)
Oct 17 2024, 9:28 AM
Unknown Object (File)
Oct 2 2024, 12:08 AM
Unknown Object (File)
Sep 27 2024, 6:00 AM
Unknown Object (File)
Sep 23 2024, 11:18 AM
Subscribers
None

Details

Summary

Ref T13137. See PHI592. Depends on D19444. Apply a limit up front to stop patches which are way too big (e.g., 600MB of videos) from generating in the first place.

Test Plan
  • Configured inline patches in git format.
  • Created a normal revision, got an inline git patch.
  • Created a revision with a 10MB video file, got no inline patch.
  • (Added a bunch of debugging stuff to make sure the internal pathway was working.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable