Page MenuHomePhabricator

Apply the new patch byte size limit to mail patch generation in Differential
ClosedPublic

Authored by epriestley on May 10 2018, 5:19 PM.
Tags
None
Referenced Files
F18741869: D19445.id46512.diff
Thu, Oct 2, 4:25 PM
F18599917: D19445.diff
Sep 13 2025, 8:34 AM
F18594908: D19445.diff
Sep 12 2025, 7:46 PM
F18565757: D19445.diff
Sep 9 2025, 1:41 PM
F18509630: D19445.id.diff
Sep 5 2025, 3:31 AM
F18502883: D19445.diff
Sep 4 2025, 10:43 PM
F18452031: D19445.id.diff
Sep 1 2025, 2:34 AM
F18437334: D19445.diff
Aug 31 2025, 12:00 PM
Subscribers
None

Details

Summary

Ref T13137. See PHI592. Depends on D19444. Apply a limit up front to stop patches which are way too big (e.g., 600MB of videos) from generating in the first place.

Test Plan
  • Configured inline patches in git format.
  • Created a normal revision, got an inline git patch.
  • Created a revision with a 10MB video file, got no inline patch.
  • (Added a bunch of debugging stuff to make sure the internal pathway was working.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable