Page MenuHomePhabricator

Apply the new patch byte size limit to mail patch generation in Differential
ClosedPublic

Authored by epriestley on May 10 2018, 5:19 PM.
Tags
None
Referenced Files
F15463629: D19445.id46520.diff
Wed, Apr 2, 1:37 AM
F15454935: D19445.diff
Sat, Mar 29, 9:21 PM
F15438868: D19445.id.diff
Wed, Mar 26, 4:13 AM
F15436315: D19445.diff
Tue, Mar 25, 1:23 PM
F15427444: D19445.diff
Sun, Mar 23, 2:31 PM
F15415958: D19445.diff
Thu, Mar 20, 8:34 AM
F15397124: D19445.id.diff
Sun, Mar 16, 6:19 PM
Unknown Object (File)
Feb 21 2025, 2:56 AM
Subscribers
None

Details

Summary

Ref T13137. See PHI592. Depends on D19444. Apply a limit up front to stop patches which are way too big (e.g., 600MB of videos) from generating in the first place.

Test Plan
  • Configured inline patches in git format.
  • Created a normal revision, got an inline git patch.
  • Created a revision with a 10MB video file, got no inline patch.
  • (Added a bunch of debugging stuff to make sure the internal pathway was working.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable