Page MenuHomePhabricator

Apply the new patch byte size limit to mail patch generation in Differential
ClosedPublic

Authored by epriestley on May 10 2018, 5:19 PM.
Tags
None
Referenced Files
F19823188: D19445.id46512.diff
Sat, Mar 7, 10:40 AM
F19819282: D19445.id46512.diff
Fri, Mar 6, 5:02 AM
F19819278: D19445.id46512.diff
Fri, Mar 6, 5:01 AM
F19709370: D19445.id46512.diff
Wed, Feb 11, 2:22 PM
F18867755: D19445.id.diff
Nov 4 2025, 2:29 AM
F18865418: D19445.diff
Nov 3 2025, 12:13 PM
F18841580: D19445.diff
Oct 28 2025, 9:56 AM
F18836958: D19445.diff
Oct 27 2025, 4:01 AM
Subscribers
None

Details

Summary

Ref T13137. See PHI592. Depends on D19444. Apply a limit up front to stop patches which are way too big (e.g., 600MB of videos) from generating in the first place.

Test Plan
  • Configured inline patches in git format.
  • Created a normal revision, got an inline git patch.
  • Created a revision with a 10MB video file, got no inline patch.
  • (Added a bunch of debugging stuff to make sure the internal pathway was working.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable