Page MenuHomePhabricator
Differential D19394

Update install_ubuntu.sh to the new age
ClosedPublic
Actions

Authored by avivey on Apr 21 2018, 4:49 AM.
Tags
None
Referenced Files
F14062655: D19394.diff
Mon, Nov 18, 1:33 PM
F13998465: D19394.diff
Thu, Oct 24, 9:25 AM
F13979245: D19394.id46399.diff
Oct 19 2024, 3:31 AM
F13969613: D19394.id46394.diff
Oct 17 2024, 3:24 AM
F13967777: D19394.diff
Oct 16 2024, 3:51 PM
F13959873: D19394.id46394.diff
Oct 14 2024, 9:06 PM
Unknown Object (File)
Oct 12 2024, 1:12 PM
Unknown Object (File)
Oct 12 2024, 11:46 AM
View All Files
Subscribers
amckinley
Korvin
Tokens
"Doubloon" token, awarded by epriestley.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4200: Building OS packages and install scripts
Commits
rP15e6e2adea61: Update install_ubuntu.sh to the new age
Summary

Ref T4200. Since the last time this script was written, Ubuntu has made lots of changes.
Try to keep up with those.

Test Plan

Ran this on frash installs of Ubuntu 16.04 LTS and 18.04 LTS (Pre-release).
Got to see Phabricator running.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningscripts/install/install_ubuntu.sh:8TXT3Line Too Long
Warningscripts/install/install_ubuntu.sh:14TXT3Line Too Long
Warningscripts/install/install_ubuntu.sh:55TXT3Line Too Long
Warningscripts/install/install_ubuntu.sh:67TXT3Line Too Long
Unit
No Test Coverage
Build Status
Buildable 20207
Build 27421: Run Core Tests
Build 27420: arc lint + arc unit

Event Timeline

avivey created this revision.Apr 21 2018, 4:49 AM
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 21 2018, 4:49 AM
Harbormaster completed remote builds in B20207: Diff 46394.Apr 21 2018, 4:50 AM
avivey requested review of this revision.Apr 21 2018, 4:50 AM
Herald added a subscriber: Korvin. · View Herald TranscriptApr 21 2018, 4:50 AM
avivey added a comment.Apr 21 2018, 4:51 AM

Incidentally, the first page shown after the install (as of 4dc8e2de564f48) is a white exception page with [Core Exception/Exception] Define 'phabricator.base-uri' in your configuration to continue..

amckinley added a subscriber: amckinley.Apr 21 2018, 2:08 PM
amckinley added inline comments.
scripts/install/install_ubuntu.sh
123

“Configuring”

epriestley added a comment.Apr 21 2018, 2:09 PM

I do sort of like the ring of "confuguring".

epriestley added a comment.EditedApr 21 2018, 2:10 PM

Incidentally, the first page shown after the install

I'll take a look at this, I think I have happen to have a repro on my less-explodey new laptop.

epriestley mentioned this in D19396: Fix excessively severe CSP URI error during first-time setup.Apr 21 2018, 4:31 PM
epriestley accepted this revision.Apr 21 2018, 4:43 PM

I didn't catch anything substantive beyond the typo @amckinley caught.

D19396 should fix the base-uri thing.

scripts/install/install_ubuntu.sh
8

Maybe better as https://phurl.io/u/install.

This revision is now accepted and ready to land.Apr 21 2018, 4:43 PM
epriestley awarded a token.Apr 21 2018, 4:43 PM
epriestley mentioned this in rP7622f6afccf4: Fix excessively severe CSP URI error during first-time setup.Apr 21 2018, 4:43 PM
Closed by commit rP15e6e2adea61: Update install_ubuntu.sh to the new age (authored by avivey). · Explain WhyApr 21 2018, 4:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
scripts/
install/
89 lines

Diff 46394

View Options

scripts/install/install_ubuntu.sh

Loading...
Phabricator · Built by Phacility