Page MenuHomePhabricator

Fix excessively severe CSP URI error during first-time setup
ClosedPublic

Authored by epriestley on Apr 21 2018, 4:31 PM.
Tags
None
Referenced Files
F19366108: D19396.id46397.diff
Fri, Dec 26, 12:56 PM
F19149377: D19396.id46398.diff
Wed, Dec 10, 7:48 PM
F19149344: D19396.id46398.diff
Wed, Dec 10, 7:45 PM
F19143712: D19396.diff
Wed, Dec 10, 2:27 PM
F19106142: D19396.id.diff
Dec 6 2025, 9:01 PM
F18911616: D19396.id46398.diff
Nov 9 2025, 4:09 AM
F18858178: D19396.id.diff
Nov 1 2025, 9:04 PM
F18854231: D19396.diff
Oct 31 2025, 10:37 PM
Subscribers
None

Details

Summary

See D19394. Currently, during first-time setup before you configure "phabricator.base-uri", we may attempt to generate a setup page, try to generate a CSP header for it, and fail to access the environmental config. This causes a too-severe error page ("configure phabricator.base-uri") instead of preflight guidance (like "can't connect to MySQL").

Instead, treat this more like "security.alternate-file-domain" and just bail on CSP if we can't fetch it.

Test Plan

On a fresh (non-explodey laptop) install with critical setup errors (no MySQL installed yet), loaded Phabricator. Before: error about phabricator.base-uri. After: more helpful guidance about installing/configuring MySQL.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable