Page MenuHomePhabricator

Fix a fatal in the document engine blame view with files that blame to the initial commit
ClosedPublic

Authored by epriestley on Apr 20 2018, 7:55 PM.
Tags
None
Referenced Files
F15459938: D19391.id.diff
Mon, Mar 31, 6:29 PM
F15456530: D19391.diff
Sun, Mar 30, 10:23 AM
F15426721: D19391.id46391.diff
Sun, Mar 23, 10:35 AM
F15423366: D19391.id.diff
Sat, Mar 22, 3:10 PM
F15421489: D19391.diff
Sat, Mar 22, 12:15 AM
F15311820: D19391.id46385.diff
Mar 6 2025, 11:27 AM
F15302742: D19391.id46391.diff
Mar 5 2025, 8:54 PM
Unknown Object (File)
Feb 27 2025, 2:54 AM
Subscribers
None

Details

Summary

Ref T13126. When you view a file using the new document engine view and some lines were introduced in the initial commit to the repository, Git renders "^abc123" in the blame output.

We currently don't do anything about this, and later fail to look it up and fatal.

It's also unlikely-but-conceivably-possible to end up here if a commit has not imported yet or has been nuked with bin/remove destroy.

Let the whole thing run without fataling even if a $commit is missing. Future refinements could improve this behavior.

Test Plan

Viewed a file with lines introduced in the initial commit, got empty blame instead of a fatal.

Diff Detail

Repository
rP Phabricator
Branch
initial1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20198
Build 27409: Run Core Tests
Build 27408: arc lint + arc unit