Page MenuHomePhabricator

Fix a fatal in the document engine blame view with files that blame to the initial commit
ClosedPublic

Authored by epriestley on Apr 20 2018, 7:55 PM.
Tags
None
Referenced Files
F15311820: D19391.id46385.diff
Thu, Mar 6, 11:27 AM
F15302742: D19391.id46391.diff
Wed, Mar 5, 8:54 PM
Unknown Object (File)
Thu, Feb 27, 2:54 AM
Unknown Object (File)
Wed, Feb 26, 8:32 PM
Unknown Object (File)
Wed, Feb 26, 8:47 AM
Unknown Object (File)
Wed, Feb 26, 12:55 AM
Unknown Object (File)
Thu, Feb 20, 9:46 PM
Unknown Object (File)
Thu, Feb 20, 9:46 PM
Subscribers
None

Details

Summary

Ref T13126. When you view a file using the new document engine view and some lines were introduced in the initial commit to the repository, Git renders "^abc123" in the blame output.

We currently don't do anything about this, and later fail to look it up and fatal.

It's also unlikely-but-conceivably-possible to end up here if a commit has not imported yet or has been nuked with bin/remove destroy.

Let the whole thing run without fataling even if a $commit is missing. Future refinements could improve this behavior.

Test Plan

Viewed a file with lines introduced in the initial commit, got empty blame instead of a fatal.

Diff Detail

Repository
rP Phabricator
Branch
initial1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20198
Build 27409: Run Core Tests
Build 27408: arc lint + arc unit