Page MenuHomePhabricator

Fix a fatal in the document engine blame view with files that blame to the initial commit
ClosedPublic

Authored by epriestley on Apr 20 2018, 7:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 11, 3:01 PM
Unknown Object (File)
Fri, Oct 11, 2:59 PM
Unknown Object (File)
Fri, Oct 11, 2:58 PM
Unknown Object (File)
Fri, Oct 11, 2:56 PM
Unknown Object (File)
Wed, Oct 9, 9:26 AM
Unknown Object (File)
Thu, Oct 3, 9:16 AM
Unknown Object (File)
Thu, Oct 3, 4:14 AM
Unknown Object (File)
Tue, Oct 1, 3:53 PM
Subscribers
None

Details

Summary

Ref T13126. When you view a file using the new document engine view and some lines were introduced in the initial commit to the repository, Git renders "^abc123" in the blame output.

We currently don't do anything about this, and later fail to look it up and fatal.

It's also unlikely-but-conceivably-possible to end up here if a commit has not imported yet or has been nuked with bin/remove destroy.

Let the whole thing run without fataling even if a $commit is missing. Future refinements could improve this behavior.

Test Plan

Viewed a file with lines introduced in the initial commit, got empty blame instead of a fatal.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable