Page MenuHomePhabricator

Fix a fatal in the document engine blame view with files that blame to the initial commit
ClosedPublic

Authored by epriestley on Apr 20 2018, 7:55 PM.
Tags
None
Referenced Files
F18432515: D19391.id46385.diff
Sun, Aug 31, 6:44 AM
F18220011: D19391.id.diff
Tue, Aug 19, 1:31 PM
F18208858: D19391.diff
Mon, Aug 18, 9:58 PM
F17921936: D19391.id46391.diff
Jul 30 2025, 6:03 AM
F17818852: D19391.id46385.diff
Jul 26 2025, 12:43 AM
F17668758: D19391.id46385.diff
Jul 12 2025, 11:25 PM
F17631540: D19391.id46391.diff
Jul 10 2025, 1:46 PM
F17631016: D19391.id46385.diff
Jul 10 2025, 12:28 PM
Subscribers
None

Details

Summary

Ref T13126. When you view a file using the new document engine view and some lines were introduced in the initial commit to the repository, Git renders "^abc123" in the blame output.

We currently don't do anything about this, and later fail to look it up and fatal.

It's also unlikely-but-conceivably-possible to end up here if a commit has not imported yet or has been nuked with bin/remove destroy.

Let the whole thing run without fataling even if a $commit is missing. Future refinements could improve this behavior.

Test Plan

Viewed a file with lines introduced in the initial commit, got empty blame instead of a fatal.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable