Page MenuHomePhabricator

Fix a fatal in the document engine blame view with files that blame to the initial commit
ClosedPublic

Authored by epriestley on Apr 20 2018, 7:55 PM.
Tags
None
Referenced Files
F13331342: D19391.diff
Mon, Jun 17, 6:31 AM
F13318600: D19391.diff
Thu, Jun 13, 11:16 AM
F13304191: D19391.diff
Sat, Jun 8, 8:43 AM
F13288248: D19391.diff
Tue, Jun 4, 10:03 AM
F13276262: D19391.diff
Fri, May 31, 5:45 AM
F13222794: D19391.diff
May 19 2024, 3:58 AM
F13205865: D19391.diff
May 15 2024, 2:49 AM
F13189128: D19391.diff
May 11 2024, 5:44 AM
Subscribers
None

Details

Summary

Ref T13126. When you view a file using the new document engine view and some lines were introduced in the initial commit to the repository, Git renders "^abc123" in the blame output.

We currently don't do anything about this, and later fail to look it up and fatal.

It's also unlikely-but-conceivably-possible to end up here if a commit has not imported yet or has been nuked with bin/remove destroy.

Let the whole thing run without fataling even if a $commit is missing. Future refinements could improve this behavior.

Test Plan

Viewed a file with lines introduced in the initial commit, got empty blame instead of a fatal.

Diff Detail

Repository
rP Phabricator
Branch
initial1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20198
Build 27409: Run Core Tests
Build 27408: arc lint + arc unit