Page MenuHomePhabricator

Fix a fatal in the document engine blame view with files that blame to the initial commit
ClosedPublic

Authored by epriestley on Apr 20 2018, 7:55 PM.
Tags
None
Referenced Files
F19909368: D19391.id46385.diff
Thu, Apr 2, 12:27 AM
F19908814: D19391.id46385.diff
Wed, Apr 1, 10:06 PM
F19891109: D19391.id.diff
Thu, Mar 26, 11:31 PM
F19880103: D19391.id46385.diff
Wed, Mar 18, 2:34 AM
F19836426: D19391.id46385.diff
Mar 11 2026, 10:21 AM
F19827979: D19391.id46391.diff
Mar 9 2026, 3:05 PM
F19827128: D19391.id46391.diff
Mar 9 2026, 6:09 AM
F19517808: D19391.id.diff
Jan 15 2026, 3:43 PM
Subscribers
None

Details

Summary

Ref T13126. When you view a file using the new document engine view and some lines were introduced in the initial commit to the repository, Git renders "^abc123" in the blame output.

We currently don't do anything about this, and later fail to look it up and fatal.

It's also unlikely-but-conceivably-possible to end up here if a commit has not imported yet or has been nuked with bin/remove destroy.

Let the whole thing run without fataling even if a $commit is missing. Future refinements could improve this behavior.

Test Plan

Viewed a file with lines introduced in the initial commit, got empty blame instead of a fatal.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable