Page MenuHomePhabricator

Fix a fatal in the document engine blame view with files that blame to the initial commit

Authored by epriestley on Apr 20 2018, 7:55 PM.
Referenced Files
F13222794: D19391.diff
Sun, May 19, 3:58 AM
F13205865: D19391.diff
Wed, May 15, 2:49 AM
F13189128: D19391.diff
Sat, May 11, 5:44 AM
Unknown Object (File)
Tue, May 7, 9:29 AM
Unknown Object (File)
Fri, May 3, 9:17 AM
Unknown Object (File)
Tue, Apr 30, 5:44 AM
Unknown Object (File)
Thu, Apr 25, 2:54 AM
Unknown Object (File)
Apr 11 2024, 10:24 AM



Ref T13126. When you view a file using the new document engine view and some lines were introduced in the initial commit to the repository, Git renders "^abc123" in the blame output.

We currently don't do anything about this, and later fail to look it up and fatal.

It's also unlikely-but-conceivably-possible to end up here if a commit has not imported yet or has been nuked with bin/remove destroy.

Let the whole thing run without fataling even if a $commit is missing. Future refinements could improve this behavior.

Test Plan

Viewed a file with lines introduced in the initial commit, got empty blame instead of a fatal.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable