Page MenuHomePhabricator

Fix a fatal in the document engine blame view with files that blame to the initial commit
ClosedPublic

Authored by epriestley on Apr 20 2018, 7:55 PM.
Tags
None
Referenced Files
F18874180: D19391.id.diff
Nov 5 2025, 1:28 PM
F18871407: D19391.diff
Nov 4 2025, 10:34 PM
F18684526: D19391.diff
Sep 26 2025, 9:39 AM
F18659551: D19391.id46391.diff
Sep 23 2025, 1:20 PM
F18658805: D19391.id46385.diff
Sep 23 2025, 8:30 AM
F18654505: D19391.id.diff
Sep 22 2025, 12:27 PM
F18654086: D19391.diff
Sep 22 2025, 2:23 AM
F18652057: D19391.id46391.diff
Sep 21 2025, 6:28 AM
Subscribers
None

Details

Summary

Ref T13126. When you view a file using the new document engine view and some lines were introduced in the initial commit to the repository, Git renders "^abc123" in the blame output.

We currently don't do anything about this, and later fail to look it up and fatal.

It's also unlikely-but-conceivably-possible to end up here if a commit has not imported yet or has been nuked with bin/remove destroy.

Let the whole thing run without fataling even if a $commit is missing. Future refinements could improve this behavior.

Test Plan

Viewed a file with lines introduced in the initial commit, got empty blame instead of a fatal.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable