Page MenuHomePhabricator
Differential D19360

Toggle revision "shouldBroadcast" correctly when "--draft" is used with prototypes off
ClosedPublic
Actions

Authored by epriestley on Apr 12 2018, 9:50 PM.
Tags
None
Referenced Files
F17756424: D19360.diff
Tue, Jul 22, 2:06 PM
F17631118: D19360.id.diff
Thu, Jul 10, 12:35 PM
F17627822: D19360.id46313.diff
Thu, Jul 10, 6:52 AM
F17608100: D19360.diff
Wed, Jul 9, 4:25 AM
Unknown Object (File)
Tue, Jul 1, 10:30 PM
Unknown Object (File)
Tue, Jul 1, 10:28 PM
Unknown Object (File)
Tue, Jul 1, 12:39 PM
Unknown Object (File)
Tue, Jul 1, 1:11 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13120: Plans: 2018 Week 15 Bonus Content
Commits
rP7e0bdbe00796: (stable) Toggle revision "shouldBroadcast" correctly when "--draft" is used…
rP4068aaef61a0: Toggle revision "shouldBroadcast" correctly when "--draft" is used with…
Summary

See PHI573. Ref T13120. Drafts were recently changed so that "draft" and "broadcast" are separate flags, and you can have non-broadcasting revisions in states other than "draft" if builds fail on a draft or you abandon a draft.

However, when draft mode is entered with arc diff --draft and you have prototypes off, this flag wasn't being set correctly.

Test Plan

Disabled prototypes, created a revision with arc diff --draft, observed that draft.broadcast is now correctly false.

Diff Detail

Repository
rP Phabricator
Branch
draft1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20127
Build 27306: Run Core Tests
Build 27305: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 12 2018, 9:50 PM
epriestley added a comment.Apr 12 2018, 9:51 PM

Roughly, this is mirroring the logic in DifferentialRevision::initializeNewRevision() introduced in D19284:

https://secure.phabricator.com/D19284#change-yYHadGHexpIu

Harbormaster completed remote builds in B20127: Diff 46310.Apr 12 2018, 9:51 PM
epriestley requested review of this revision.Apr 12 2018, 9:51 PM
amckinley accepted this revision.Apr 12 2018, 10:53 PM
This revision is now accepted and ready to land.Apr 12 2018, 10:53 PM
Closed by commit rP4068aaef61a0: Toggle revision "shouldBroadcast" correctly when "--draft" is used with… (authored by epriestley). · Explain WhyApr 12 2018, 11:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
xaction/
4 lines

Diff 46310

View Options

src/applications/differential/xaction/DifferentialRevisionHoldDraftTransaction.php

Loading...
Phabricator · Built by Phacility