Page MenuHomePhabricator

Toggle revision "shouldBroadcast" correctly when "--draft" is used with prototypes off
ClosedPublic

Authored by epriestley on Apr 12 2018, 9:50 PM.
Tags
None
Referenced Files
F15373019: D19360.diff
Wed, Mar 12, 2:16 PM
F15318199: D19360.diff
Thu, Mar 6, 8:14 PM
Unknown Object (File)
Tue, Feb 25, 11:36 AM
Unknown Object (File)
Feb 9 2025, 5:55 AM
Unknown Object (File)
Feb 9 2025, 5:55 AM
Unknown Object (File)
Feb 9 2025, 5:54 AM
Unknown Object (File)
Feb 9 2025, 5:54 AM
Unknown Object (File)
Jan 28 2025, 3:45 AM
Subscribers
None

Details

Summary

See PHI573. Ref T13120. Drafts were recently changed so that "draft" and "broadcast" are separate flags, and you can have non-broadcasting revisions in states other than "draft" if builds fail on a draft or you abandon a draft.

However, when draft mode is entered with arc diff --draft and you have prototypes off, this flag wasn't being set correctly.

Test Plan

Disabled prototypes, created a revision with arc diff --draft, observed that draft.broadcast is now correctly false.

Diff Detail

Repository
rP Phabricator
Branch
draft1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20127
Build 27306: Run Core Tests
Build 27305: arc lint + arc unit

Event Timeline

Roughly, this is mirroring the logic in DifferentialRevision::initializeNewRevision() introduced in D19284:

https://secure.phabricator.com/D19284#change-yYHadGHexpIu

This revision is now accepted and ready to land.Apr 12 2018, 10:53 PM
This revision was automatically updated to reflect the committed changes.