Page MenuHomePhabricator

Treat Owners paths like "/src/backend" and "/src/backend/" identically
ClosedPublic

Authored by epriestley on Mar 7 2018, 4:14 AM.
Tags
None
Referenced Files
F15525824: D19184.diff
Mon, Apr 21, 5:07 PM
F15514221: D19184.diff
Fri, Apr 18, 1:08 AM
F15499859: D19184.diff
Sun, Apr 13, 3:19 PM
F15480952: D19184.id45946.diff
Tue, Apr 8, 5:31 PM
F15474336: D19184.diff
Sun, Apr 6, 7:31 AM
F15459882: D19184.id45951.diff
Mon, Mar 31, 5:31 PM
F15459881: D19184.id.diff
Mon, Mar 31, 5:31 PM
F15459880: D19184.id45946.diff
Mon, Mar 31, 5:31 PM
Subscribers
None

Details

Summary

Depends on D19183. Ref T11015. Currently, adding a trailing slash works great and omitting it mysteriously doesn't work.

Store a normalized version with an unconditional trailing slash for the lookup logic to operate on, and a separate display version which tracks what the user actually typed.

Test Plan
  • Entered "/src/main.c", "/src/main.c/", saw them de-duplicate.
  • Entered "/src/main.c", saw it stay that way in the UI but appear as "/src/main.c/" internally.
  • Added a rule for "/src/applications/owners" (no slash), created a revision touching paths in that directory, saw Owners fire for it.
  • Changed the display value of a path only ("/src/main.c" to "/src/main.c/"), saw the update reflected in the UI without any beahvioral change.

Diff Detail

Repository
rP Phabricator
Branch
opath4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19759
Build 26766: Run Core Tests
Build 26765: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 7 2018, 4:31 AM
This revision was automatically updated to reflect the committed changes.