Page MenuHomePhabricator

Treat Owners paths like "/src/backend" and "/src/backend/" identically
ClosedPublic

Authored by epriestley on Mar 7 2018, 4:14 AM.
Tags
None
Referenced Files
F17711937: D19184.diff
Thu, Jul 17, 9:19 AM
Unknown Object (File)
Fri, Jul 4, 10:50 PM
Unknown Object (File)
Jun 26 2025, 8:58 PM
Unknown Object (File)
Jun 15 2025, 3:47 PM
Unknown Object (File)
Jun 1 2025, 1:04 PM
Unknown Object (File)
May 31 2025, 4:51 AM
Unknown Object (File)
May 27 2025, 3:35 PM
Unknown Object (File)
May 26 2025, 11:03 PM
Subscribers
None

Details

Summary

Depends on D19183. Ref T11015. Currently, adding a trailing slash works great and omitting it mysteriously doesn't work.

Store a normalized version with an unconditional trailing slash for the lookup logic to operate on, and a separate display version which tracks what the user actually typed.

Test Plan
  • Entered "/src/main.c", "/src/main.c/", saw them de-duplicate.
  • Entered "/src/main.c", saw it stay that way in the UI but appear as "/src/main.c/" internally.
  • Added a rule for "/src/applications/owners" (no slash), created a revision touching paths in that directory, saw Owners fire for it.
  • Changed the display value of a path only ("/src/main.c" to "/src/main.c/"), saw the update reflected in the UI without any beahvioral change.

Diff Detail

Repository
rP Phabricator
Branch
opath4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19759
Build 26766: Run Core Tests
Build 26765: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 7 2018, 4:31 AM
This revision was automatically updated to reflect the committed changes.