Page MenuHomePhabricator

Treat Owners paths like "/src/backend" and "/src/backend/" identically
ClosedPublic

Authored by epriestley on Mar 7 2018, 4:14 AM.
Tags
None
Referenced Files
F19563156: D19184.diff
Sat, Jan 31, 3:17 PM
F19549859: D19184.id45951.diff
Tue, Jan 27, 3:03 PM
F19130999: D19184.diff
Dec 10 2025, 5:46 AM
F19054608: D19184.id45951.diff
Nov 28 2025, 1:53 PM
F18989166: D19184.diff
Nov 18 2025, 10:48 AM
F18944373: D19184.id45951.diff
Nov 11 2025, 3:56 PM
F18944368: D19184.id45946.diff
Nov 11 2025, 3:55 PM
F18825905: D19184.id45946.diff
Oct 24 2025, 12:58 AM
Subscribers
None

Details

Summary

Depends on D19183. Ref T11015. Currently, adding a trailing slash works great and omitting it mysteriously doesn't work.

Store a normalized version with an unconditional trailing slash for the lookup logic to operate on, and a separate display version which tracks what the user actually typed.

Test Plan
  • Entered "/src/main.c", "/src/main.c/", saw them de-duplicate.
  • Entered "/src/main.c", saw it stay that way in the UI but appear as "/src/main.c/" internally.
  • Added a rule for "/src/applications/owners" (no slash), created a revision touching paths in that directory, saw Owners fire for it.
  • Changed the display value of a path only ("/src/main.c" to "/src/main.c/"), saw the update reflected in the UI without any beahvioral change.

Diff Detail

Repository
rP Phabricator
Branch
opath4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19759
Build 26766: Run Core Tests
Build 26765: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 7 2018, 4:31 AM
This revision was automatically updated to reflect the committed changes.