Page MenuHomePhabricator

Move Paste line range reading code into AphrontRequest
ClosedPublic

Authored by epriestley on Mar 1 2018, 2:11 PM.
Tags
None
Referenced Files
F15509399: D19162.id.diff
Wed, Apr 16, 12:08 PM
F15506304: D19162.id45902.diff
Tue, Apr 15, 10:05 AM
F15474946: D19162.id45908.diff
Sun, Apr 6, 2:23 PM
F15463010: D19162.id45902.diff
Tue, Apr 1, 7:44 PM
F15427143: D19162.id45908.diff
Sun, Mar 23, 1:06 PM
F15392173: D19162.id.diff
Mar 15 2025, 1:37 PM
F15391994: D19162.id45908.diff
Mar 15 2025, 12:44 PM
F15391859: D19162.id45902.diff
Mar 15 2025, 12:00 PM
Subscribers
None

Details

Summary

Ref T13088. This lifts the code for parsing "$x-y" line ranges in URIs into AphrontRequest so Diffusion, Paste, Harbormaster, etc., can share it.

Test Plan

Viewed lines, line ranges, no lines, negative line ranges, line ranges with 0, and extremely long line ranges in Paste.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable