Page MenuHomePhabricator

Move Paste line range reading code into AphrontRequest
ClosedPublic

Authored by epriestley on Mar 1 2018, 2:11 PM.
Tags
None
Referenced Files
F18581252: D19162.id45902.diff
Thu, Sep 11, 5:26 AM
F18573083: D19162.diff
Wed, Sep 10, 7:59 AM
F18566683: D19162.id.diff
Tue, Sep 9, 2:49 PM
F18502288: D19162.diff
Thu, Sep 4, 10:20 PM
F18109653: D19162.id.diff
Aug 11 2025, 2:48 PM
F18106764: D19162.diff
Aug 10 2025, 11:21 PM
F18094936: D19162.id.diff
Aug 7 2025, 10:26 PM
F17734116: D19162.id45902.diff
Jul 20 2025, 10:01 AM
Subscribers
None

Details

Summary

Ref T13088. This lifts the code for parsing "$x-y" line ranges in URIs into AphrontRequest so Diffusion, Paste, Harbormaster, etc., can share it.

Test Plan

Viewed lines, line ranges, no lines, negative line ranges, line ranges with 0, and extremely long line ranges in Paste.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable