Page MenuHomePhabricator
Differential D19165

Share the Paste line highlighting behavior for Harbormaster build logs
ClosedPublic
Actions

Authored by epriestley on Mar 1 2018, 4:04 PM.
Tags
None
Referenced Files
F13235951: D19165.id45905.diff
Tue, May 21, 7:16 AM
Unknown Object (File)
Sun, May 5, 10:22 AM
Unknown Object (File)
Thu, May 2, 5:32 AM
Unknown Object (File)
Apr 19 2024, 7:29 PM
Unknown Object (File)
Apr 3 2024, 9:23 PM
Unknown Object (File)
Mar 30 2024, 6:07 AM
Unknown Object (File)
Mar 25 2024, 9:30 AM
Unknown Object (File)
Mar 5 2024, 1:45 PM
View All 91 Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13088: Plans: Harbormaster UI usability and interconnectedness
Commits
rP73619c4643c9: Share the Paste line highlighting behavior for Harbormaster build logs
Summary

Depends on D19164. Ref T13088. Now that the JS behaviors are generic, use them on the Harbormaster standalone page.

Test Plan

Clicked lines and dragged across line ranges. Reloaded pages. Saw expected highlighting behavior in the client and on the server across reloads.

Diff Detail

Repository
rP Phabricator
Branch
harbor4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19714
Build 26702: Run Core Tests
Build 26701: arc lint + arc unit

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
harbormaster/
controller/
14 lines
3 lines
view/
10 lines
webroot/
rsrc/
css/
application/
harbormaster/
6 lines

Diff 45905

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildLogViewController.php

Loading...
View Options

src/applications/harbormaster/view/HarbormasterBuildLogView.php

Loading...
View Options

webroot/rsrc/css/application/harbormaster/harbormaster.css

Loading...
Phabricator · Built by Phacility