Page MenuHomePhabricator
Differential D19164

Make Paste source code line highlighting behavior more generic
ClosedPublic
Actions

Authored by epriestley on Mar 1 2018, 3:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 16, 6:18 PM
Unknown Object (File)
Sat, Feb 15, 10:10 AM
Unknown Object (File)
Sun, Feb 9, 6:04 PM
Unknown Object (File)
Sun, Feb 9, 5:35 AM
Unknown Object (File)
Sun, Feb 9, 5:35 AM
Unknown Object (File)
Sun, Feb 9, 5:35 AM
Unknown Object (File)
Jan 28 2025, 3:29 AM
Unknown Object (File)
Jan 25 2025, 12:26 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13088: Plans: Harbormaster UI usability and interconnectedness
Commits
rPfe3de5dd58b4: Make Paste source code line highlighting behavior more generic
Summary

Depends on D19163. Ref T13088. Increase the generality of this code so it can be shared with Harbormaster.

Test Plan

Clicked individual lines, clicked-and-dragged, etc., in Paste. Got sensible URI and highlight behaviors.

Diff Detail

Repository
rP Phabricator
Branch
harbor3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19713
Build 26700: Run Core Tests
Build 26699: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 1 2018, 3:46 PM
Harbormaster completed remote builds in B19713: Diff 45904.Mar 1 2018, 3:47 PM
epriestley requested review of this revision.Mar 1 2018, 3:47 PM
epriestley added a child revision: D19165: Share the Paste line highlighting behavior for Harbormaster build logs.Mar 1 2018, 4:04 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 1 2018, 8:46 PM
Closed by commit rPfe3de5dd58b4: Make Paste source code line highlighting behavior more generic (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
20 lines
src/
view/
layout/
14 lines
webroot/
rsrc/
css/
layout/
11 lines
js/
core/
122 lines

Diff 45904

View Options

resources/celerity/map.php

Loading...
View Options

src/view/layout/PhabricatorSourceCodeView.php

Loading...
View Options

webroot/rsrc/css/layout/phabricator-source-code-view.css

Loading...
View Options

webroot/rsrc/js/core/behavior-line-linker.js

Loading...
Phabricator · Built by Phacility