Differential D19162

Move Paste line range reading code into AphrontRequest
ClosedPublic
Actions

Authored by epriestley on Mar 1 2018, 2:11 PM.

Details

Reviewers: None
Maniphest Tasks: T13088: Plans: Harbormaster UI usability and interconnectedness
Commits: rP4466402c5a6d: Move Paste line range reading code into AphrontRequest

Summary

Ref T13088. This lifts the code for parsing "$x-y" line ranges in URIs into AphrontRequest so Diffusion, Paste, Harbormaster, etc., can share it.

Test Plan

Viewed lines, line ranges, no lines, negative line ranges, line ranges with 0, and extremely long line ranges in Paste.

Diff Detail

Repository

rP Phabricator

Branch

harbor1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19711
Build 26696: Run Core Tests
Build 26695: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 1 2018, 2:11 PM

Harbormaster completed remote builds in B19711: Diff 45902.Mar 1 2018, 2:13 PM

epriestley requested review of this revision.Mar 1 2018, 2:13 PM

epriestley added a child revision: D19163: Support rendering arbitrary sections in the middle of a Harbormaster build log so links to line 3500 work.Mar 1 2018, 3:12 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 1 2018, 7:15 PM

Closed by commit rP4466402c5a6d: Move Paste line range reading code into AphrontRequest (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

aphront/

AphrontRequest.php

48 lines

applications/

paste/

controller/

PhabricatorPasteViewController.php

29 lines

Diff 45902

View Options

src/aphront/AphrontRequest.php