Page MenuHomePhabricator

Move Paste line range reading code into AphrontRequest
ClosedPublic

Authored by epriestley on Mar 1 2018, 2:11 PM.
Tags
None
Referenced Files
F15463010: D19162.id45902.diff
Tue, Apr 1, 7:44 PM
F15427143: D19162.id45908.diff
Sun, Mar 23, 1:06 PM
F15392173: D19162.id.diff
Sat, Mar 15, 1:37 PM
F15391994: D19162.id45908.diff
Sat, Mar 15, 12:44 PM
F15391859: D19162.id45902.diff
Sat, Mar 15, 12:00 PM
F15375944: D19162.id45908.diff
Thu, Mar 13, 12:50 AM
F15344519: D19162.id45902.diff
Mon, Mar 10, 5:02 AM
F15344297: D19162.id45902.diff
Mon, Mar 10, 3:41 AM
Subscribers
None

Details

Summary

Ref T13088. This lifts the code for parsing "$x-y" line ranges in URIs into AphrontRequest so Diffusion, Paste, Harbormaster, etc., can share it.

Test Plan

Viewed lines, line ranges, no lines, negative line ranges, line ranges with 0, and extremely long line ranges in Paste.

Diff Detail

Repository
rP Phabricator
Branch
harbor1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19711
Build 26696: Run Core Tests
Build 26695: arc lint + arc unit