Render object remarkup references in a text context as "Dxxx <uri>"
ClosedPublic
Actions

Authored by epriestley on Feb 8 2018, 5:50 PM.

Details

Reviewers: None
Maniphest Tasks: T11389: Object links merged in plain text email
Commits: rP0402a79e0e57: Render object remarkup references in a text context as "Dxxx <uri>"

Summary

Depends on D19031. Fixes T11389. Currently, we render Dxxx in a text context (plain text email) as just a URI.

Instead, render it like Dxxx <uri>. This is more faithful to the original intent and preserves T123/T456 as two separate, usable links.

Test Plan

Wrote T123/T234 in a task, pulled mail for it with bin/mail show-outbound, saw separate clickable links.

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

epriestley requested review of this revision.Feb 8 2018, 5:51 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2018, 5:52 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

src/

infrastructure/

markup/

rule/

2 lines