Page MenuHomePhabricator

Render object remarkup references in a text context as "Dxxx <uri>"
ClosedPublic

Authored by epriestley on Feb 8 2018, 5:50 PM.
Tags
None
Referenced Files
F13149819: D19032.diff
Sat, May 4, 11:36 AM
Unknown Object (File)
Wed, May 1, 9:06 PM
Unknown Object (File)
Mon, Apr 29, 2:48 PM
Unknown Object (File)
Wed, Apr 24, 10:47 PM
Unknown Object (File)
Mar 28 2024, 10:17 PM
Unknown Object (File)
Mar 23 2024, 5:06 AM
Unknown Object (File)
Mar 23 2024, 5:06 AM
Unknown Object (File)
Mar 23 2024, 5:06 AM
Subscribers
None

Details

Summary

Depends on D19031. Fixes T11389. Currently, we render Dxxx in a text context (plain text email) as just a URI.

Instead, render it like Dxxx <uri>. This is more faithful to the original intent and preserves T123/T456 as two separate, usable links.

Test Plan

Wrote T123/T234 in a task, pulled mail for it with bin/mail show-outbound, saw separate clickable links.

Diff Detail

Repository
rP Phabricator
Branch
mail8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19428
Build 26276: Run Core Tests
Build 26275: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2018, 5:52 PM
This revision was automatically updated to reflect the committed changes.