Improve PHP7 handling of include-time parser-like fatals like "class must implement all abstract methods"
ClosedPublic
Actions

Authored by epriestley on Feb 6 2018, 1:00 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T12101: Phabricator PHP 7 Compatibility

Commits

rPHU30b002c481a6: Improve PHP7 handling of include-time parser-like fatals like "class must…

Summary

Ref T12101. Although PHP7 raises parse errors as throwables, it still just instantly fatals for some types of parser-like error.

We currently silence these, so they can cause the process to appear to exit abruptly. Instead, unsilence them.

Test Plan

Don't implement all abstract methods.
Run arc unit.
Before: silent fatal.
After: useful error.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 6 2018, 1:00 PM

Harbormaster completed remote builds in B19359: Diff 45566.Feb 6 2018, 1:00 PM

epriestley requested review of this revision.Feb 6 2018, 1:00 PM

amckinley accepted this revision.Feb 6 2018, 7:28 PM

amckinley added inline comments.

src/moduleutils/PhutilBootloader.php
234	"immediately"

This revision is now accepted and ready to land.Feb 6 2018, 7:28 PM

I figured out how to make a computer do this for me, so hopefully I'll have fewer spelling errors in comments going forward:

Screen Shot 2018-02-06 at 11.47.45 AM.png (1×960 px, 64 KB)

Use more conventional spelling.

Harbormaster completed remote builds in B19370: Diff 45576.Feb 6 2018, 7:49 PM

Closed by commit rPHU30b002c481a6: Improve PHP7 handling of include-time parser-like fatals like "class must… (authored by epriestley). · Explain WhyFeb 6 2018, 8:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

moduleutils/

PhutilBootloader.php

10 lines

Diff 45578

View Options

src/moduleutils/PhutilBootloader.php

Improve PHP7 handling of include-time parser-like fatals like "class must implement all abstract methods"ClosedPublicActions