Page MenuHomePhabricator

Improve PHP7 handling of include-time parser-like fatals like "class must implement all abstract methods"
ClosedPublic

Authored by epriestley on Feb 6 2018, 1:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 5:02 AM
Unknown Object (File)
Sat, Mar 23, 5:01 AM
Unknown Object (File)
Mon, Mar 4, 5:25 PM
Unknown Object (File)
Fri, Mar 1, 3:33 AM
Unknown Object (File)
Feb 21 2024, 11:14 AM
Unknown Object (File)
Feb 10 2024, 8:46 AM
Unknown Object (File)
Feb 3 2024, 5:58 PM
Unknown Object (File)
Feb 1 2024, 11:20 PM
Subscribers
None

Details

Summary

Ref T12101. Although PHP7 raises parse errors as throwables, it still just instantly fatals for some types of parser-like error.

We currently silence these, so they can cause the process to appear to exit abruptly. Instead, unsilence them.

Test Plan
  • Don't implement all abstract methods.
  • Run arc unit.
  • Before: silent fatal.
  • After: useful error.

Diff Detail

Repository
rPHU libphutil
Branch
php71
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19359
Build 26172: Run Core Tests
Build 26171: arc lint + arc unit

Event Timeline

amckinley added inline comments.
src/moduleutils/PhutilBootloader.php
234

"immediately"

This revision is now accepted and ready to land.Feb 6 2018, 7:28 PM

I figured out how to make a computer do this for me, so hopefully I'll have fewer spelling errors in comments going forward:

Screen Shot 2018-02-06 at 11.47.45 AM.png (1×960 px, 64 KB)

  • Use more conventional spelling.
This revision was automatically updated to reflect the committed changes.