Page MenuHomePhabricator

Improve PHP7 handling of include-time parser-like fatals like "class must implement all abstract methods"

Authored by epriestley on Feb 6 2018, 1:00 PM.



Ref T12101. Although PHP7 raises parse errors as throwables, it still just instantly fatals for some types of parser-like error.

We currently silence these, so they can cause the process to appear to exit abruptly. Instead, unsilence them.

Test Plan
  • Don't implement all abstract methods.
  • Run arc unit.
  • Before: silent fatal.
  • After: useful error.

Diff Detail

rPHU libphutil
Lint Not Applicable
Tests Not Applicable

Event Timeline

amckinley added inline comments.


This revision is now accepted and ready to land.Feb 6 2018, 7:28 PM

I figured out how to make a computer do this for me, so hopefully I'll have fewer spelling errors in comments going forward:

Screen Shot 2018-02-06 at 11.47.45 AM.png (1×960 px, 64 KB)

  • Use more conventional spelling.
This revision was automatically updated to reflect the committed changes.