Page MenuHomePhabricator
Differential D19001

Improve PHP7 handling of include-time parser-like fatals like "class must implement all abstract methods"
ClosedPublic
Actions

Authored by epriestley on Feb 6 2018, 1:00 PM.
Tags
None
Referenced Files
F15410274: D19001.diff
Wed, Mar 19, 6:59 AM
F15393936: D19001.id.diff
Sat, Mar 15, 11:17 PM
F15393934: D19001.diff
Sat, Mar 15, 11:17 PM
F15331732: D19001.diff
Fri, Mar 7, 1:12 PM
F15299643: D19001.id45578.diff
Wed, Mar 5, 3:44 PM
Unknown Object (File)
Mon, Mar 3, 6:15 PM
Unknown Object (File)
Mon, Feb 24, 4:40 AM
Unknown Object (File)
Sun, Feb 23, 8:35 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T12101: Phabricator PHP 7 Compatibility
Commits
rPHU30b002c481a6: Improve PHP7 handling of include-time parser-like fatals like "class must…
Summary

Ref T12101. Although PHP7 raises parse errors as throwables, it still just instantly fatals for some types of parser-like error.

We currently silence these, so they can cause the process to appear to exit abruptly. Instead, unsilence them.

Test Plan
  • Don't implement all abstract methods.
  • Run arc unit.
  • Before: silent fatal.
  • After: useful error.

Diff Detail

Repository
rPHU libphutil
Branch
php71
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19370
Build 26192: Run Core Tests
Build 26191: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 6 2018, 1:00 PM
Harbormaster completed remote builds in B19359: Diff 45566.Feb 6 2018, 1:00 PM
epriestley requested review of this revision.Feb 6 2018, 1:00 PM
amckinley accepted this revision.Feb 6 2018, 7:28 PM
amckinley added inline comments.
src/moduleutils/PhutilBootloader.php
234

"immediately"

This revision is now accepted and ready to land.Feb 6 2018, 7:28 PM
epriestley added a comment.Feb 6 2018, 7:48 PM

I figured out how to make a computer do this for me, so hopefully I'll have fewer spelling errors in comments going forward:

Screen Shot 2018-02-06 at 11.47.45 AM.png (1×960 px, 64 KB)

epriestley updated this revision to Diff 45576.Feb 6 2018, 7:49 PM
  • Use more conventional spelling.
Harbormaster completed remote builds in B19370: Diff 45576.Feb 6 2018, 7:49 PM
Closed by commit rPHU30b002c481a6: Improve PHP7 handling of include-time parser-like fatals like "class must… (authored by epriestley). · Explain WhyFeb 6 2018, 8:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
moduleutils/
10 lines

Diff 45576

View Options

src/moduleutils/PhutilBootloader.php

Loading...
Phabricator · Built by Phacility