Fix a possible `count(null)` in PHUIInfoView
ClosedPublic
Actions

Authored by epriestley on Jan 29 2018, 9:18 PM.

Details

Reviewers

Commits

rPf3f1f106b16b: (stable) Fix a possible `count(null)` in PHUIInfoView
rP1db281bcd1bb: Fix a possible `count(null)` in PHUIInfoView

Summary

See https://discourse.phabricator-community.org/t/php7-2-exception-count-parameter-must-be-an-array-or-an-object-that-implements-countable/1031.

PHP7.2 raises a warning about count(scalar) (GREAT!) and we have one here if the caller doesn't setErrors(...).

Test Plan

Sanity-checked usage of $this->errors.

Diff Detail

Repository

rP Phabricator

Branch

countnull

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19253
Build 26018: Run Core Tests
Build 26017: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 29 2018, 9:18 PM

Harbormaster completed remote builds in B19253: Diff 45469.Jan 29 2018, 9:19 PM

epriestley requested review of this revision.Jan 29 2018, 9:19 PM

epriestley added inline comments.Jan 29 2018, 9:20 PM

src/view/phui/PHUIInfoView.php
126	This is the possible `count(null)`.

amckinley accepted this revision.Jan 29 2018, 9:37 PM

This revision is now accepted and ready to land.Jan 29 2018, 9:37 PM

Closed by commit rP1db281bcd1bb: Fix a possible `count(null)` in PHUIInfoView (authored by epriestley). · Explain WhyJan 29 2018, 11:16 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D19140: Provide default values for table view properties which are `count`ed.Feb 25 2018, 8:43 PM

tolbrino mentioned this in D19242: Fix a possible `count(null)` in DifferentialRevisionActionTransaction.Mar 21 2018, 8:51 AM

epriestley mentioned this in rP73b68bc2a619: Fix a possible `count(null)` in DifferentialRevisionActionTransaction.Mar 21 2018, 2:39 PM

Revision Contents
Changeset List

Path

Size

src/

view/

phui/

PHUIInfoView.php

2 lines

Diff 45469

View Options

src/view/phui/PHUIInfoView.php

Fix a possible `count(null)` in PHUIInfoViewClosedPublicActions