HomePhabricator

Fix a possible `count(null)` in PHUIInfoView

Description

Fix a possible count(null) in PHUIInfoView

Summary:
See https://discourse.phabricator-community.org/t/php7-2-exception-count-parameter-must-be-an-array-or-an-object-that-implements-countable/1031.

PHP7.2 raises a warning about count(scalar) (GREAT!) and we have one here if the caller doesn't setErrors(...).

Test Plan: Sanity-checked usage of $this->errors.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18964

Details

Provenance
epriestleyAuthored on Jan 29 2018, 9:16 PM
epriestleyPushed on Jan 29 2018, 11:16 PM
Reviewer
amckinley
Differential Revision
D18964: Fix a possible `count(null)` in PHUIInfoView
Parents
rP40e9806e3c88: Remove the caret dropdown from transaction lists when no actions are available
Branches
Unknown
Tags
Unknown
Build Status
Buildable 19258
Build 26025: Run Core Tests