Page MenuHomePhabricator

Add a "Revision status" field to Herald for Differential revisions
ClosedPublic

Authored by epriestley on Jan 26 2018, 3:39 AM.
Tags
None
Referenced Files
F16489382: D18938.diff
Mon, Jun 16, 6:32 PM
Unknown Object (File)
Mon, May 26, 6:09 PM
Unknown Object (File)
May 7 2025, 3:34 AM
Unknown Object (File)
Apr 24 2025, 5:43 AM
Unknown Object (File)
Apr 23 2025, 11:16 AM
Unknown Object (File)
Apr 20 2025, 1:34 PM
Unknown Object (File)
Apr 20 2025, 8:20 AM
Unknown Object (File)
Apr 19 2025, 2:55 PM
Subscribers
None

Details

Summary

See PHI280. We have a similar field for tasks already, this is generally a reasonable sort of thing to support, and the addition of "draft" states means there are some pretty reasonable use cases.

Test Plan
  • Wrote a status-based ("status is needs revision") Herald rule.
  • Tested it against a "Needs Revision" revision (passed) and a "Changes Planned" revision (failed).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable