Differential D18938

Add a "Revision status" field to Herald for Differential revisions
ClosedPublic
Actions

Authored by epriestley on Jan 26 2018, 3:39 AM.

Tags

None

Subscribers

None

Details

Reviewers

Commits

rP3a2d33767986: Add a "Revision status" field to Herald for Differential revisions

Summary

See PHI280. We have a similar field for tasks already, this is generally a reasonable sort of thing to support, and the addition of "draft" states means there are some pretty reasonable use cases.

Test Plan

Wrote a status-based ("status is needs revision") Herald rule.
Tested it against a "Needs Revision" revision (passed) and a "Changes Planned" revision (failed).

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 26 2018, 3:39 AM

Harbormaster completed remote builds in B19192: Diff 45411.Jan 26 2018, 3:41 AM

epriestley requested review of this revision.Jan 26 2018, 3:41 AM

epriestley mentioned this in T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald.Jan 26 2018, 3:41 AM

amckinley accepted this revision.Jan 26 2018, 8:34 PM

This revision is now accepted and ready to land.Jan 26 2018, 8:34 PM

Closed by commit rP3a2d33767986: Add a "Revision status" field to Herald for Differential revisions (authored by epriestley). · Explain WhyJan 26 2018, 9:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

differential/

herald/

DifferentialRevisionStatusHeraldField.php

29 lines

Diff 45432

src/__phutil_library_map__.php

Loading...

src/applications/differential/herald/DifferentialRevisionStatusHeraldField.php

Loading...