Page MenuHomePhabricator

Add a "Revision status" field to Herald for Differential revisions
ClosedPublic

Authored by epriestley on Jan 26 2018, 3:39 AM.
Tags
None
Referenced Files
F15531446: D18938.diff
Wed, Apr 23, 11:16 AM
F15521381: D18938.id45411.diff
Sun, Apr 20, 1:34 PM
F15520781: D18938.id.diff
Sun, Apr 20, 8:20 AM
F15518605: D18938.diff
Sat, Apr 19, 2:55 PM
F15514353: D18938.id45411.diff
Fri, Apr 18, 2:12 AM
F15464290: D18938.id.diff
Wed, Apr 2, 8:12 AM
F15462437: D18938.id45432.diff
Tue, Apr 1, 3:08 PM
F15459866: D18938.id.diff
Mon, Mar 31, 5:31 PM
Subscribers
None

Details

Summary

See PHI280. We have a similar field for tasks already, this is generally a reasonable sort of thing to support, and the addition of "draft" states means there are some pretty reasonable use cases.

Test Plan
  • Wrote a status-based ("status is needs revision") Herald rule.
  • Tested it against a "Needs Revision" revision (passed) and a "Changes Planned" revision (failed).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable