Page MenuHomePhabricator

Add a "Revision status" field to Herald for Differential revisions
ClosedPublic

Authored by epriestley on Jan 26 2018, 3:39 AM.
Tags
None
Referenced Files
F22298536: D18938.id45411.diff
Sun, Aug 30, 7:21 PM
F22298531: D18938.id45432.diff
Sun, Aug 30, 7:21 PM
F22296550: D18938.diff
Sun, Aug 30, 6:17 PM
Unknown Object (File)
Jul 4 2026, 4:05 AM
Unknown Object (File)
Jul 4 2026, 4:05 AM
Unknown Object (File)
Jun 29 2026, 10:56 PM
Unknown Object (File)
Jun 28 2026, 2:54 PM
Unknown Object (File)
Jun 25 2026, 1:12 PM
Subscribers
None

Details

Summary

See PHI280. We have a similar field for tasks already, this is generally a reasonable sort of thing to support, and the addition of "draft" states means there are some pretty reasonable use cases.

Test Plan
  • Wrote a status-based ("status is needs revision") Herald rule.
  • Tested it against a "Needs Revision" revision (passed) and a "Changes Planned" revision (failed).

Diff Detail

Repository
rP Phabricator
Branch
hstatus1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19192
Build 25926: Run Core Tests
Build 25925: arc lint + arc unit