Page MenuHomePhabricator

Add a "Revision status" field to Herald for Differential revisions
ClosedPublic

Authored by epriestley on Jan 26 2018, 3:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 2, 2:41 PM
Unknown Object (File)
Sat, Mar 1, 4:42 PM
Unknown Object (File)
Wed, Feb 26, 1:50 AM
Unknown Object (File)
Fri, Feb 14, 4:10 AM
Unknown Object (File)
Sun, Feb 9, 5:04 AM
Unknown Object (File)
Sun, Feb 9, 5:04 AM
Unknown Object (File)
Sun, Feb 9, 5:04 AM
Unknown Object (File)
Sun, Feb 9, 5:04 AM
Subscribers
None

Details

Summary

See PHI280. We have a similar field for tasks already, this is generally a reasonable sort of thing to support, and the addition of "draft" states means there are some pretty reasonable use cases.

Test Plan
  • Wrote a status-based ("status is needs revision") Herald rule.
  • Tested it against a "Needs Revision" revision (passed) and a "Changes Planned" revision (failed).

Diff Detail

Repository
rP Phabricator
Branch
hstatus1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19192
Build 25926: Run Core Tests
Build 25925: arc lint + arc unit