Page MenuHomePhabricator

Make "first broadcast" rules for Differential drafts more general
ClosedPublic

Authored by epriestley on Nov 28 2017, 6:44 PM.
Tags
None
Referenced Files
F17847269: D18801.id.diff
Sun, Jul 27, 5:56 AM
F17841488: D18801.id45115.diff
Sat, Jul 26, 10:31 PM
F17836998: D18801.id45115.diff
Sat, Jul 26, 4:48 PM
F17824486: D18801.diff
Sat, Jul 26, 5:32 AM
F17823301: D18801.id.diff
Sat, Jul 26, 4:30 AM
F17803390: D18801.id45103.diff
Fri, Jul 25, 10:08 AM
F17667587: D18801.diff
Sat, Jul 12, 10:27 PM
Unknown Object (File)
Mon, Jun 30, 11:16 PM
Subscribers
None

Details

Summary

See PHI228. Ref T2543. The current logic gets this slightly wrong: prototypes are off, you create a draft with --draft, then promote it with "Request Review". This misses both branches.

Instead, test these conditions a little more broadly. We also need to store broadcast state since getIsNewObject() isn't good enough with this workflow.

Test Plan
  • With prototypes on and autopromotion, got a rich email after builds finished.
  • With prototypes off, got a rich email immediately.
  • With prototypes off and --draft, got a rich email after "Request Review".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable